Autocomplete behaviour change between 9.0 and 10.1

[Klug]

Hello.

I've been working on some upgrade from 9.0 to 10.1 this week (rolling upgrade, multi-servers).
We've noticed a change of behavior in autocomplete on the 10.1 server (mailbox moved from 9.0 to 10.1 server).

Every "autocomplete" option is check for the user (in the preferences).
There's no error/warning (timeout) in mailbox.log.

On the 10.1 server, if the recipient is in the GAL (and NOT HIDDEN in the GAL), autocomplete finds it.
On the 10.1 server, if the recipient is in the contacts or "Emailed Contacts" of the user (and NOT HIDDEN in the GAL), autocomplete finds it.
On the 10.1 server, if the recipient is in the Contacts or "Emailed Contacts" of the user BUT HIDDEN in the GAL, autocomplete doesn't find it. This is an issue.

On the 9.0 server, the recipient is found even if hidden in the GAL.

Does anyone else noticed that too?
Asking before opening a case...

[andrey.ivanov]

Yes, we had a huge problem with autocomplete after migration from 9.0 to 10.1.8 last week. We use external LDAP as GAL and we hide all the internal accounts of Zimbra LDAP ("Internal GAL") using zimbraHideInGal=TRUE. The problem is that there are some addresses in internal accounts that coincide with addresses in external LDAP GAL. So after the upgrade our users could see in autocompletion only the addresses from an external LDAP that were not hosted on Zimbra.

I have spent a couple of days troubleshooting this problem. Its origin is in the file zm-mailbox/store/src/java/com/zimbra/cs/mailbox/ContactAutoComplete.java. I have patched this file and recompiled from sources (using for example Dunphy's build helpers, thanks a lot Dunphy!!!! - https://wiki.zimbra.com/wiki/JDunphy-Co ... mbraScript).

Then i have replaced the compiled patched file ./com/zimbra/cs/mailbox/ContactAutoComplete.class in the production /opt/zimbra/lib/jars/zimbrastore.jar and it fixed our problem.

Here is the (very simplistic) patch :

Code: Select all

--- a/zm-mailbox/store/src/java/com/zimbra/cs/mailbox/ContactAutoComplete.java  2025-06-09 11:26:45.198623170 +0200
+++ b/zm-mailbox/store/src/java/com/zimbra/cs/mailbox/ContactAutoComplete.java  2025-06-06 00:29:26.534628570 +0200
@@ -776,7 +776,7 @@
             // when account is null, its external contact.Below alias logic is not applicable.
             if (null != account) {
                 // check if account needs to be hidden in autocomplete
-                if (ContactConstants.A_email.equalsIgnoreCase(emailKey) && account.isHideInGal()) {
+                if (ContactConstants.A_email.equalsIgnoreCase(emailKey) && false) {
                     ZimbraLog.gal.debug("Skipping account %s from autocomplete", getFieldAsString(attrs, emailKey));
                     continue;
                 }
@@ -969,4 +969,4 @@
             queryFolders(str, queryRanking, mountpoints, limit, result);
         }
     }
-}
\ No newline at end of file
+}

If this problem is fixed upstream, it will largely simplify our Zimbra maintenance. If not, i will have to patch every single time when /opt/zimbra/lib/jars/zimbrastore.jar will be updated from an rpm
If you need it i could attach the patched .class file and/or the patched zimbrastore.jar file (for commercial version 10.1.8)

[Klug]

So I'm not crazy

Did you open a bug already so they at least acknowledge the behavior change?

[andrey.ivanov]

Nope, i did not open the bug, i was in "urgent fix it" mode. )

[Klug]

Rolling upgrade saved our ass on this: we migrated only a few people of IT team and one of them experienced the issue...
So we postponed additional mailboxes migration until we find out about this.

I've opened a case: 01824545

I'm interested in your .jar in the meantime

[Thomasfrank01]

I find the issue you raised very specific and noteworthy. Have you tried to check if this change is due to the processing logic on the Zimbra 10.1 side or maybe due to a change in Zimlet or proxy/nginx configuration? Are there any release notes that clearly state this behavior change?

[andrey.ivanov]

Thanks for opening the case!

I made some tests before migration and i did check that autocompletion works. However i did not check the details of the mails in autocomplete suggestions

The file (zimbrastore-patched-10.1.8.jar) is here : https://filesender.renater.fr/?s=downlo ... a1ce418af7
You can check its content and compare with the original /opt/zimbra/lib/jars/zimbrastore.jar using "jar xf". You should have only one different file - ContactAutoComplete.class

sha256sum is af1fb1ce23f744b9e90b55b28b225e75e90ec6e2dadc80203bfa76a54013bb12

[Klug]

Thank you!
Sending it to customer right now so they can test.

[Klug]

Support was able to reproduce the issue and gave me a bug number: ZBUG-4936

Actually the bug is known at least since "Tue, 10 Jun 2025 14:08:28 GMT".

[oetiker]

does anyone have that patched version of the zimbrastore.jar file ?